Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add error stack to cmd entrence #16391

Merged
merged 4 commits into from
Sep 5, 2024
Merged

Conversation

andylokandy
Copy link
Collaborator

@andylokandy andylokandy commented Sep 4, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 4, 2024
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Sep 4, 2024
@andylokandy andylokandy requested a review from sundy-li September 4, 2024 14:21
Copy link

what-the-diff bot commented Sep 5, 2024

PR Summary

Key changes in src/binaries/query directory

This PR heavily modifies error handling in the application by making use of a common error handling library and a new MainError type for main functions like run_cmd and start_services in the query binary.

  • Enhancement in error handling
    The ee_main.rs, entry.rs and oss_main.rs files in the query binary now leverage databend_common_exception::ResultExt and entry::MainError for error handling improving error tracking and debugging.

Major updates in src/common/base/src/runtime directory

  • CatchUnwindError Struct Added
    The catch_unwind.rs file now includes a CatchUnwindError struct to handle errors better in runtime.

  • Block error handling improved
    The runtime.rs file has adjusted the handling of blocking on a future by mapping a failure to a CatchUnwindError.

Important modifications in src/common/exception/src directory

  • Exception handling tweaked
    The context.rs and exception.rs files have had several adjustments improving the clarity and information provided from errors.

Critical changes in src/query/service/src/interpreters directory

  • Interpreter error handling refined
    The interpreter.rs file and interpreter_table_recluster.rs file have introduced databend_common_exception::ResultExt for enhanced error management during execution.

Various files updated

Various files have been updated to implement databend_common_exception::ResultExt, which will help to handle errors more proficiently throughout the software. Notably, changes are made in query log, executor_graph, pipeline_executor, http_query. query_ctx, session, commit, gc, navigate, and several test files are also updated to use ResultExt.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 5, 2024
@BohuTANG BohuTANG merged commit c2e29ca into databendlabs:main Sep 5, 2024
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer pr-chore this PR only has small changes that no need to record, like coding styles. size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants