Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix cargo clippy #16397

Merged
merged 1 commit into from
Sep 5, 2024
Merged

chore(ci): fix cargo clippy #16397

merged 1 commit into from
Sep 5, 2024

Conversation

TCeason
Copy link
Collaborator

@TCeason TCeason commented Sep 5, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

fix clippy err

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 5, 2024
Copy link

what-the-diff bot commented Sep 5, 2024

PR Summary

  • Removal of the Tenant Variable
    The tenant variable, which was previously part of the Binder structure in the bind_table.rs file, has been removed. This could lead to a more straightforward way of managing data within the Binder. The exact impacts will depend on the specific uses of the Binder structure within the program.

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Sep 5, 2024
@TCeason
Copy link
Collaborator Author

TCeason commented Sep 5, 2024

Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @BohuTANG)

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 5, 2024
@BohuTANG BohuTANG merged commit 841e1f7 into databendlabs:main Sep 5, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer pr-chore this PR only has small changes that no need to record, like coding styles. size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants