Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(query): add external server request profile #16400

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

zhang2014
Copy link
Member

@zhang2014 zhang2014 commented Sep 5, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

chore(query): add external server request profile

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - add profile

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 5, 2024
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Sep 5, 2024
Copy link

what-the-diff bot commented Sep 5, 2024

PR Summary

  • Profile Statistics Update
    The code updates include a new statistic measure termed ExternalServerRequestCount in the application's profile statistics. This is part of the measure that provides details on the number of external server requests made by the application.

  • Changes to Explain Interpreter
    The 'ExplainInterpreter' which helps in understanding how your queries are processed, has been refined. The modifications ensure certain initial and final operations are excluded from the interpretation process for two types of pipelines (explain pipeline and sources pipelines).

  • Enhancements in Recording Functionality
    A new update allows an increase in the ExternalServerRequestCount value by one every time the specific code is run in transform_udf_server.rs. This helps keep track of the number of external server requests made during the execution of this file.

@dosubot dosubot bot added A-query Area: databend query C-observability Category: Profiling, tracing labels Sep 5, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Sep 5, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 5, 2024
@BohuTANG BohuTANG merged commit 2c8f5a8 into databendlabs:main Sep 5, 2024
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-query Area: databend query C-observability Category: Profiling, tracing lgtm This PR has been approved by a maintainer pr-chore this PR only has small changes that no need to record, like coding styles. size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants