Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: compact after merge sort #16401

Merged
merged 2 commits into from
Sep 7, 2024
Merged

Conversation

zhyass
Copy link
Member

@zhyass zhyass commented Sep 5, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Run compact after merge sort during recluster

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 5, 2024
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Sep 5, 2024
Copy link

what-the-diff bot commented Sep 5, 2024

PR Summary

  • Addition of a new compact block process
    A new file titled transform_block_compact_without_split.rs was introduced. This houses the newly structured BlockCompactorWithoutSplit.

  • Implementation of the Compactor trait
    In order to cater to block compacting needs, this trait has been implemented in the newly added file.

  • Enhancement to the builder reclustering process
    Some adjustments have been made to the builder_recluster.rs file, which now includes BlockCompactorWithoutSplit and TransformCompact. As a result, the pipeline will compact data blocks post-merge sort.

  • Test file modifications
    Some changes have been applied to 09_0008_fuse_optimize_table.test file , more specifically removing the insert into t15 values(5) statement and then adding a fresh insert into t15 values(-7) statement.

@dosubot dosubot bot added A-query Area: databend query C-feature Category: feature labels Sep 5, 2024
@zhyass zhyass marked this pull request as draft September 5, 2024 10:58
@zhyass zhyass added the ci-benchmark Benchmark: run all test label Sep 5, 2024
Copy link
Contributor

github-actions bot commented Sep 5, 2024

Docker Image for PR

  • tag: pr-16401-826b99b-1725542588

note: this image tag is only available for internal use,
please check the internal doc for more details.

@zhyass zhyass marked this pull request as ready for review September 6, 2024 18:14
@zhyass zhyass requested review from BohuTANG, zhang2014, dantengsky and sundy-li and removed request for BohuTANG September 6, 2024 18:14
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 7, 2024
Copy link
Contributor

github-actions bot commented Sep 7, 2024

Docker Image for PR

  • tag: pr-16401-ed274fe-1725680548

note: this image tag is only available for internal use,
please check the internal doc for more details.

gix-path: improperly resolves configuration path reported by Git
@dantengsky dantengsky added this pull request to the merge queue Sep 7, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Sep 7, 2024
@BohuTANG BohuTANG merged commit a954b63 into databendlabs:main Sep 7, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-query Area: databend query C-feature Category: feature ci-benchmark Benchmark: run all test lgtm This PR has been approved by a maintainer pr-feature this PR introduces a new feature to the codebase size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants