Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(query): add connect duration metric for udf #16407

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

zhang2014
Copy link
Member

@zhang2014 zhang2014 commented Sep 6, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

chore(query): add connect duration metric for udf

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - add metrics

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 6, 2024
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Sep 6, 2024
Copy link

what-the-diff bot commented Sep 6, 2024

PR Summary

  • Introduction of Connection Duration Measurement
    The code has been adjusted to now measure and record the time it takes to establish connections to external servers. We've introduced a new defined term METRIC_CONNECT_EXTERNAL_DURATION that will help with this measurement and a function called record_connect_external_duration that will help track this information.

  • Utilizing New Measurement in the UDF Transformation Server
    The same function record_connect_external_duration has also been incorporated into our UDF (User-Defined Function) Transformation Server, enabling us to understand how long connecting to external resources takes during data transformations.

Overall, these changes should help with monitoring and troubleshooting, making it easier to spot and resolve issues related to connection times.

@dosubot dosubot bot added the A-query Area: databend query label Sep 6, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 6, 2024
@BohuTANG
Copy link
Member

BohuTANG commented Sep 6, 2024

Conflicting files
src/query/service/src/pipelines/processors/transforms/transform_udf_server.rs

@BohuTANG BohuTANG merged commit dd21d7d into databendlabs:main Sep 6, 2024
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-query Area: databend query lgtm This PR has been approved by a maintainer pr-chore this PR only has small changes that no need to record, like coding styles. size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants