Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update dependency datafusion-orc. #16491

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented Sep 23, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

fix #16490

the branch we used is simply rebased to the main

  1. to fix the issue fast, so we can get ride of datafusion as dep right now, and avoid other potential dep problems.
  2. because the changes in the branch is temporary not suitable to pr to upstream.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 23, 2024
@youngsofun youngsofun marked this pull request as draft September 23, 2024 03:42
@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Sep 23, 2024
@dosubot dosubot bot added the dependencies Pull requests that update a dependency file label Sep 23, 2024
Cargo.toml Outdated Show resolved Hide resolved
@youngsofun youngsofun requested a review from sundy-li September 23, 2024 10:40
@youngsofun youngsofun marked this pull request as ready for review September 23, 2024 10:40
@youngsofun youngsofun requested a review from BohuTANG September 23, 2024 14:27
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 23, 2024
@sundy-li sundy-li added this pull request to the merge queue Sep 23, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Sep 23, 2024
@BohuTANG BohuTANG merged commit 13258d0 into databendlabs:main Sep 23, 2024
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file lgtm This PR has been approved by a maintainer pr-refactor this PR changes the code base without new features or bugfix size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

orc-rust needs to be upgraded
3 participants