Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove logs from block writer #16497

Merged

Conversation

dantengsky
Copy link
Member

@dantengsky dantengsky commented Sep 23, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

remove log message from block writer:

  • log messages of writing bloom index
  • log messages of writing revert index

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - tweak logs only

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Sep 23, 2024
- log message of writing bloom index
- log message of writing revert index
@dantengsky dantengsky force-pushed the chore-cleaup-block-writer-log branch from 7de8692 to 6a6126b Compare September 23, 2024 09:09
@dantengsky dantengsky marked this pull request as ready for review September 23, 2024 10:43
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 23, 2024
@dantengsky dantengsky requested a review from zhyass September 23, 2024 10:43
@dosubot dosubot bot added the A-storage Area: databend storage label Sep 23, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 23, 2024
@BohuTANG BohuTANG merged commit 414c99c into databendlabs:main Sep 23, 2024
95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-storage Area: databend storage lgtm This PR has been approved by a maintainer pr-chore this PR only has small changes that no need to record, like coding styles. size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants