Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(query): add more logs on aggregation #16552

Merged
merged 7 commits into from
Oct 14, 2024
Merged

chore(query): add more logs on aggregation #16552

merged 7 commits into from
Oct 14, 2024

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Sep 30, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  1. add more logs on aggregation
  2. add comment about [profile.release] in cargo.toml
  3. optimize aggregate unary function

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Sep 30, 2024
@sundy-li sundy-li requested review from b41sh and zhang2014 October 12, 2024 03:26
@sundy-li sundy-li added this pull request to the merge queue Oct 13, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 13, 2024
@sundy-li
chore(query): add more logs on aggregation (#16552)
6d7de32 
* add consume_convert_blocks:

* update

* add tests

* add more logs

* add more logs
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 13, 2024
@sundy-li sundy-li added this pull request to the merge queue Oct 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 14, 2024
@BohuTANG BohuTANG merged commit d249097 into databendlabs:main Oct 14, 2024
71 checks passed
@andylokandy andylokandy mentioned this pull request Oct 25, 2024
Merged
11 tasks
sundy-li added a commit to sundy-li/databend that referenced this pull request Dec 3, 2024
@sundy-li
chore(query): add more logs on aggregation (databendlabs#16552)
36b0ab7 
* add consume_convert_blocks:

* update

* add tests

* add more logs

* add more logs
dantengsky pushed a commit that referenced this pull request Dec 3, 2024
@sundy-li @everpcpc
chore(query): cherrypick to 636: Decimal128 state use align 8 (#16989)
62abe30 
* chore(query): add more logs on aggregation (#16552)

* add consume_convert_blocks:

* update

* add tests

* add more logs

* add more logs

* chore(query): improve decimal aggregate state

* update

* update

* update

* chore(ci): upgrade bendsql (#16965)

* chore(ci): install bendsql from packages (#16970)

---------

Co-authored-by: everpcpc <[email protected]>
dantengsky pushed a commit that referenced this pull request Dec 15, 2024
@sundy-li @everpcpc
chore(query): cherrypick to 636: Decimal128 state use align 8 (#16989)
964a086 
* chore(query): add more logs on aggregation (#16552)

* add consume_convert_blocks:

* update

* add tests

* add more logs

* add more logs

* chore(query): improve decimal aggregate state

* update

* update

* update

* chore(ci): upgrade bendsql (#16965)

* chore(ci): install bendsql from packages (#16970)

---------

Co-authored-by: everpcpc <[email protected]>
dantengsky pushed a commit to dantengsky/fuse-query that referenced this pull request Dec 16, 2024
@sundy-li @everpcpc @dantengsky
chore(query): cherrypick to 636: Decimal128 state use align 8 (databe…
bc2c38d 
…ndlabs#16989)

* chore(query): add more logs on aggregation (databendlabs#16552)

* add consume_convert_blocks:

* update

* add tests

* add more logs

* add more logs

* chore(query): improve decimal aggregate state

* update

* update

* update

* chore(ci): upgrade bendsql (databendlabs#16965)

* chore(ci): install bendsql from packages (databendlabs#16970)

---------

Co-authored-by: everpcpc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhang2014 zhang2014 zhang2014 approved these changes

@b41sh b41sh Awaiting requested review from b41sh

Assignees
No one assigned
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sundy-li @zhang2014 @BohuTANG