refactor: add SchemaApi::get_table_in_db #16582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-refactor
In cases where the `database-id` is already known, use this method to get a table as replacement of `get_table()`. `get_table()` re-fetch database-id by database-name, thus leads to additional unnecessary delay and potential consistency issues, because a database may already be renamed, and using the original database-name just gets the wrong database instance.
drmingdrmer
force-pushed
the
159-get-table
branch
from
63d81ca to
f310d11
Compare
11 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
refactor: add SchemaApi::get_table_in_db
In cases where the
database-idis already known, use this method toget a table as replacement of
get_table().get_table()re-fetchdatabase-id by database-name, thus leads to additional unnecessary delay
and potential consistency issues, because a database may already be
renamed, and using the original database-name just gets the wrong
database instance.
Tests
Type of change
Related Issues
This change is