Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): support subquery in pivot #16631

Merged
merged 5 commits into from
Oct 20, 2024

Conversation

Dragonliu2018
Copy link
Contributor

@Dragonliu2018 Dragonliu2018 commented Oct 17, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Pivot supports subquery now. For example, the following three types of queries:

  1. from + subquery:
SELECT *
FROM (select * from monthly_sales)
PIVOT(SUM(amount) FOR MONTH IN ('JAN', 'FEB', 'MAR', 'APR'))
ORDER BY EMPID;
  1. in + subquery:
SELECT * 
FROM monthly_sales
PIVOT(SUM(amount) FOR MONTH IN (select distinct month from monthly_sales))
ORDER BY EMPID;
  1. combination:
  SELECT * 
  FROM (select * from monthly_sales)
  PIVOT(SUM(amount) FOR MONTH IN (select distinct month from monthly_sales))
  ORDER BY EMPID;

Reproduce document: https://docs.databend.com/sql/sql-commands/query-syntax/query-pivot


Unpivot currently only supports the from + subquery type of subquery, consistent with Snowflake's behavior.

SELECT * FROM (SELECT * FROM monthly_sales_1)
UNPIVOT(sales FOR month IN (jan, feb, mar, april))
ORDER BY empid;

Snowflakes reference document: https://docs.snowflake.com/en/sql-reference/constructs/unpivot
Reproduce document: https://docs.databend.com/sql/sql-commands/query-syntax/query-unpivot

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Oct 17, 2024
@BohuTANG BohuTANG requested a review from sundy-li October 17, 2024 06:37
@b41sh b41sh self-requested a review October 17, 2024 07:03
@b41sh b41sh added this pull request to the merge queue Oct 20, 2024
Merged via the queue into databendlabs:main with commit 4557131 Oct 20, 2024
72 checks passed
Dousir9 pushed a commit to dantengsky/fuse-query that referenced this pull request Nov 27, 2024
* fix(query): support subquery in pivot

* add pivot and unpivot sqllogictests, fix unit-test

* code format
dantengsky added a commit that referenced this pull request Nov 27, 2024
)

* feat: implement `is_not_null` selectivity based on null count in stats (#16730)

* feat: implement is_not_null selectivity based on null count in stats

* fix test

* chore(planner): improve cardinality estimation (#16938)

* chore(planner): improve cardinality estimation

* chore(planner): improve histogram cardinality estimation

* chore(planner): improve join cardinality

* chore(test): update sqllogictest

* chore(test): update sqllogictest

* chore(code): refine code

* chore(test): update sqllogictest

* chore(test): test ci tpch

* chore(code): fix typos

* chore(test): remove accurate_his test

* chore(test): fix sqllogictest

* chore(query): fix sub overflow

* chore(planner): refine scan histogram

* chore(test): update sqllogictest

* chore(test): update sqllogictest

* ci: fix flaky test  (#16945)

* ci: fix flaky test #16935

* ci: update error format of Bendsql.

* feat: filter null value before join (#16722)

* feat: filter null value before join

* fix lint

* add annotations and process possible crash

* dedup filters and fix tests (also need to fix native explain test)

* fix test

* support semi join

* fix test for semi join

* adjust threshold and enable only distribution

* chore(planner): resolve conflicts

* fix(query): support subquery in pivot (#16631)

* fix(query): support subquery in pivot

* add pivot and unpivot sqllogictests, fix unit-test

* code format

* chore(code): resolve conflicts

* chore(test): update sqllogictest

* chore(test): update sqllogictest

* Revert "ci: fix flaky test  (#16945)"

This reverts commit efcbac3.

* chore: add extra bracket for `and` and  `or` to make explain clear (#16494)

* fix: add extra bracket for and or

* add task test

* chore(test): update sqllogictest

* Revert "Revert "ci: fix flaky test  (#16945)""

This reverts commit 49ea151.

* fix(query): forbid explain explain statement (#16654)

fix(query): forbiden explain explain statement

* fix(ci): flaky test (#16933)

* flaky test

* fix

* fix test

* chore(code): resolve conflicts

* chore(test): update test

---------

Co-authored-by: xudong.w <[email protected]>
Co-authored-by: Jk Xu <[email protected]>
Co-authored-by: Yang Xiufeng <[email protected]>
Co-authored-by: Liu Zhenlong <[email protected]>
Co-authored-by: Dousir9 <[email protected]>
Co-authored-by: TCeason <[email protected]>
Co-authored-by: zhya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: pivot query can not support subquery
3 participants