Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(query): add warn log if vacuum temporary file is error #16646

Merged
merged 1 commit into from
Oct 21, 2024
Merged

chore(query): add warn log if vacuum temporary file is error #16646

merged 1 commit into from
Oct 21, 2024

Conversation

zhang2014
Copy link
Member

@zhang2014 zhang2014 commented Oct 21, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

chore(query): add warn log if vacuum temporary file is error

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - add more log

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@zhang2014 zhang2014 requested a review from Xuanwo October 21, 2024 02:29
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Oct 21, 2024
@zhang2014 zhang2014 added this pull request to the merge queue Oct 21, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Oct 21, 2024
@BohuTANG BohuTANG merged commit 894656f into databendlabs:main Oct 21, 2024
75 checks passed
@andylokandy andylokandy mentioned this pull request Oct 25, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhang2014 @Xuanwo @BohuTANG