Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support pushdown predicate into iceberg engine #16650

Merged
merged 7 commits into from
Nov 12, 2024
Merged

feat: support pushdown predicate into iceberg engine #16650

merged 7 commits into from
Nov 12, 2024

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Oct 21, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  1. support pushdown filter predicate into iceberg engine
  2. fix bug: incorrect result of eq expr #16647

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@sundy-li sundy-li requested a review from Xuanwo October 21, 2024 08:53
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Oct 21, 2024
@Xuanwo
Copy link
Member

Xuanwo commented Oct 21, 2024

Thank you for working on this!

Xuanwo
Xuanwo approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@sundy-li sundy-li requested a review from andylokandy October 21, 2024 09:30
@sundy-li
Copy link
Member Author

need upgrade iceberg and opendal @Xuanwo

@sundy-li sundy-li marked this pull request as draft October 21, 2024 23:05
@Xuanwo
Copy link
Member

Xuanwo commented Oct 22, 2024

need upgrade iceberg and opendal @Xuanwo

Yep, I will work on this.

@sundy-li sundy-li marked this pull request as ready for review November 12, 2024 07:12
@BohuTANG BohuTANG merged commit a34da6f into databendlabs:main Nov 12, 2024
77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@andylokandy andylokandy Awaiting requested review from andylokandy

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: incorrect result of eq expr
3 participants
@sundy-li @Xuanwo @BohuTANG