Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): sort spilling use arrow file format painc #16658

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

forsaken628
Copy link
Collaborator

@forsaken628 forsaken628 commented Oct 22, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

fixes: #16660

SortSpillMetaWithParams is not allowed to be cloned, but DataBlock::concat will clone it, so we need take out the meta from block before spilling.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Oct 22, 2024
Signed-off-by: coldWater <[email protected]>
Signed-off-by: coldWater <[email protected]>
@forsaken628 forsaken628 changed the title fix(query): sort spilling fail (WIP) fix(query): sort spilling use arrow file format painc Oct 23, 2024
@forsaken628 forsaken628 requested a review from sundy-li October 23, 2024 01:52
@forsaken628 forsaken628 marked this pull request as ready for review October 23, 2024 02:00
@sundy-li sundy-li added this pull request to the merge queue Oct 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 23, 2024
@BohuTANG BohuTANG merged commit 3d19b30 into databendlabs:main Oct 23, 2024
90 checks passed
@forsaken628 forsaken628 deleted the fix-sort-spill branch October 29, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Unimplented clone SortSpillMeta
3 participants