Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: JEAllocator should properly handle nullptr returned #16692

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

dantengsky
Copy link
Member

@dantengsky dantengsky commented Oct 25, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

In JEAllocator::grow_zeroed/shrink, when je rallocx returns NULL, stop proceeding, returns AllocError error directly.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Oct 25, 2024
@dantengsky dantengsky force-pushed the fix-jemalloc-allocator branch from 60c1a6d to a5fe90d Compare October 26, 2024 02:43
@dantengsky dantengsky marked this pull request as ready for review October 28, 2024 03:47
@BohuTANG BohuTANG merged commit 1aa6dfa into databendlabs:main Oct 28, 2024
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants