Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove transaction keyword #16707

Merged
merged 2 commits into from
Oct 28, 2024
Merged

chore: remove transaction keyword #16707

merged 2 commits into from
Oct 28, 2024

Conversation

SkyFan2002
Copy link
Member

@SkyFan2002 SkyFan2002 commented Oct 28, 2024 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Oct 28, 2024
@SkyFan2002 SkyFan2002 changed the title chore: remove tranction keyword chore: remove transaction keyword Oct 28, 2024
@SkyFan2002 SkyFan2002 marked this pull request as ready for review October 28, 2024 11:24
@sundy-li sundy-li added this pull request to the merge queue Oct 28, 2024
Merged via the queue into databendlabs:main with commit 82814bf Oct 28, 2024
81 checks passed
dantengsky pushed a commit that referenced this pull request Oct 28, 2024
@SkyFan2002 @dantengsky
chore: remove transaction keyword (#16707)
d6eb8b1 
* chore: remove tranction keyword

* add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li approved these changes

@andylokandy andylokandy Awaiting requested review from andylokandy

@dantengsky dantengsky Awaiting requested review from dantengsky

Assignees
No one assigned
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SkyFan2002 @sundy-li