refactor: refine column statistic map serialization #16728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr-refactor
dantengsky
force-pushed
the
refactor-col-stats-ser
branch
from
8e009a1 to
765aba7
Compare
While serializing ColumnStatistics map, excludes columns which is of unsupported type
dantengsky
force-pushed
the
refactor-col-stats-ser
branch
from
765aba7 to
b448823
Compare
andylokandy
approved these changes
Oct 30, 2024
dantengsky
added a commit
that referenced
this pull request
Oct 30, 2024
While serializing ColumnStatistics map, excludes columns which is of unsupported type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
This PR modifies the serialization process for the ColumnStatistics map to exclude columns of unsupported types.
When merging snapshots or block metadata, column statistics may include legacy types that are no longer supported. If these columns are not excluded, serialization will fail.
The changes introduced in #16719 allow legacy type scalars to be de-serialized. If these legacy columns are present in the column statistics during de-serialization, they will be excluded to prevent runtime errors.
Tests
Type of change
This change is