Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(query): add last_day, previous_day, next_day function #16740

Merged
merged 5 commits into from
Nov 7, 2024
Merged

feat(query): add last_day, previous_day, next_day function #16740

merged 5 commits into from
Nov 7, 2024

Conversation

Freejww
Copy link
Contributor

@Freejww Freejww commented Oct 31, 2024 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Support function: last_day, next_day and previous_day.

fixes: #16715

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Oct 31, 2024
@Freejww
Copy link
Contributor Author

Freejww commented Oct 31, 2024

Hi, I ran failed ci tests locally, the result is 0. PTAL. @TCeason

@TCeason
Copy link
Collaborator

TCeason commented Oct 31, 2024

Hi, I ran failed ci tests locally, the result is 0. PTAL. @TCeason

#16739 fix it.

@Freejww
Copy link
Contributor Author

Freejww commented Oct 31, 2024

Hi, I ran failed ci tests locally, the result is 0. PTAL. @TCeason

#16739 fix it.

Thanks~

@Freejww
Copy link
Contributor Author

Freejww commented Nov 5, 2024

Hi，this pr is ready for review. @TCeason

@Freejww Freejww requested a review from TCeason November 7, 2024 13:21
@TCeason TCeason mentioned this pull request Nov 7, 2024
Closed
@TCeason TCeason added this pull request to the merge queue Nov 7, 2024
Merged via the queue into databendlabs:main with commit 806210c Nov 7, 2024
73 of 74 checks passed
@wubx
Copy link
Member

wubx commented Nov 9, 2024

cc @soyeric128 need doc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TCeason TCeason TCeason approved these changes

Assignees
No one assigned
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Support function: last_day, next_day and previous_day
3 participants
@Freejww @TCeason @wubx