Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: HTTP handle lost rows when result set is wide and large. #16748

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented Nov 1, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

may lost a row starting from the 3rd page, when

  1. total size > 20MB.
  2. avg row size > 1050B.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

when
1. total size > 20MB.
2. avg row size > 1050B.
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Nov 1, 2024
@youngsofun youngsofun enabled auto-merge November 1, 2024 07:02
@youngsofun youngsofun added this pull request to the merge queue Nov 1, 2024
Merged via the queue into databendlabs:main with commit 7d218c1 Nov 1, 2024
78 of 81 checks passed
@youngsofun youngsofun deleted the fix_http branch November 1, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants