Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Files::remove_file_in_batch should not swallow errors #16761

Merged
merged 1 commit into from
Nov 4, 2024
Merged

fix: Files::remove_file_in_batch should not swallow errors #16761

merged 1 commit into from
Nov 4, 2024

Conversation

dantengsky
Copy link
Member

@dantengsky dantengsky commented Nov 4, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Files::remove_file_in_batch should not swallow errors

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Nov 4, 2024
@dantengsky dantengsky force-pushed the fix-files-remove_file_in_batch-should-not-swallow-err branch from fc49e0b to 0d48058 Compare November 4, 2024 12:33
@dantengsky dantengsky marked this pull request as ready for review November 4, 2024 13:05
@dantengsky dantengsky requested a review from SkyFan2002 November 4, 2024 13:05
@dantengsky dantengsky added this pull request to the merge queue Nov 4, 2024
Merged via the queue into databendlabs:main with commit db32c8d Nov 4, 2024
154 checks passed
@dantengsky dantengsky deleted the fix-files-remove_file_in_batch-should-not-swallow-err branch November 4, 2024 14:58
dantengsky added a commit to dantengsky/fuse-query that referenced this pull request Nov 4, 2024
@dantengsky
fix: Files::remove_file_in_batch should not swallow errors (databen…
a9fbf1c 
…dlabs#16761)
@dantengsky dantengsky mentioned this pull request Nov 4, 2024
Merged
11 tasks
dantengsky added a commit to dantengsky/fuse-query that referenced this pull request Nov 4, 2024
@dantengsky
fix: Files::remove_file_in_batch should not swallow errors (databen…
969d3eb 
…dlabs#16761)
dantengsky added a commit to dantengsky/fuse-query that referenced this pull request Nov 4, 2024
@dantengsky
fix: Files::remove_file_in_batch should not swallow errors (databen…
71c29c8 
…dlabs#16761)
dantengsky added a commit that referenced this pull request Nov 4, 2024
@dantengsky
chore: backport PR #16761 release/v1.2.636 rc3 (#16762)
e172254 
* fix: `Files::remove_file_in_batch` should not swallow errors (#16761)

* resolve unit test cherry pick conflict
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SkyFan2002 SkyFan2002 SkyFan2002 approved these changes

Assignees
No one assigned
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dantengsky @SkyFan2002