refactor: make ListKV non-blocking by returning stream directly #16868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return Stream to client instead of collecting results into Vec first. This change eliminates unnecessary buffering of ListKV results in databend-meta server, reducing memory usage and improving response times. The direct streaming approach better matches current usage patterns and removes legacy collection behavior. Although a large ListKV response body won't block the databend-meta server, but it will still block on the client side.
drmingdrmer
changed the title
github-actions
bot
added
the
pr-refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
perf: make ListKV non-blocking by returning stream directly
Return Stream to client instead of collecting results into Vec first.
This change eliminates unnecessary buffering of ListKV results in
databend-meta server, reducing memory usage and improving response
times. The direct streaming approach better matches current usage
patterns and removes legacy collection behavior.
Although a large ListKV response body won't block the databend-meta
server, but it will still block on the client side.
Tests
Type of change
Related Issues
This change is