Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): fix incorrect total_bytes_len in string view #16877

Merged
merged 6 commits into from
Nov 21, 2024

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Nov 20, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  1. add more asserts
  2. fix incorrect total_bytes_len in string view

using const UNKNOWN_LEN: u64 = u64::MAX to track with the total_bytes_len was a bad idea cause it may introduce overflow during add/sub.

closes #16880

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Nov 20, 2024
@sundy-li sundy-li changed the title chore(query): add more asserts fix(query): add more asserts Nov 20, 2024
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Nov 20, 2024
@sundy-li sundy-li changed the title fix(query): add more asserts fix(query): fix incorrect total_bytes_len in string view Nov 20, 2024
@sundy-li sundy-li requested a review from b41sh November 20, 2024 08:15
@sundy-li sundy-li marked this pull request as ready for review November 20, 2024 08:16
@sundy-li sundy-li requested a review from andylokandy November 20, 2024 08:16
@sundy-li sundy-li enabled auto-merge November 20, 2024 08:30
@sundy-li sundy-li added this pull request to the merge queue Nov 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 20, 2024
@sundy-li sundy-li added this pull request to the merge queue Nov 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 21, 2024
@BohuTANG BohuTANG merged commit bb5e2e6 into databendlabs:main Nov 21, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: StringView panic with map and array value
4 participants