Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sqlsmith): refactor sqlsmith using http client #16890

Merged
merged 4 commits into from
Nov 23, 2024

Conversation

b41sh
Copy link
Member

@b41sh b41sh commented Nov 20, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  • refactor sqlsmith using http client, remove bendsql client to reduce dependence.
  • generate random geometry expr.
  • fix sort row convert panic caused by unsupported types.

fixes: #[Link the issue here]

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@b41sh b41sh requested review from sundy-li and TCeason November 20, 2024 15:09
@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Nov 20, 2024
@TCeason
Copy link
Collaborator

TCeason commented Nov 20, 2024

refactor sqlsmith using mysql client, remove bendsql client to reduce dependence

Why do this?

@b41sh b41sh marked this pull request as draft November 21, 2024 10:29
@b41sh b41sh force-pushed the refactor-sqlsmith-client branch from 3b5f3f3 to f3d8ce0 Compare November 22, 2024 09:36
@b41sh b41sh changed the title refactor(sqlsmith): refactor sqlsmith using mysql client refactor(sqlsmith): refactor sqlsmith using http client Nov 22, 2024
@b41sh b41sh force-pushed the refactor-sqlsmith-client branch from f3d8ce0 to 92703fc Compare November 22, 2024 09:42
@b41sh b41sh marked this pull request as ready for review November 22, 2024 09:42
Copy link
Collaborator

@TCeason TCeason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@b41sh b41sh marked this pull request as draft November 22, 2024 10:57
@b41sh b41sh marked this pull request as ready for review November 22, 2024 15:43
@b41sh b41sh enabled auto-merge November 23, 2024 02:51
@b41sh b41sh added this pull request to the merge queue Nov 23, 2024
Merged via the queue into databendlabs:main with commit 221018b Nov 23, 2024
78 checks passed
@b41sh b41sh deleted the refactor-sqlsmith-client branch November 23, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants