-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ignore case when matching function name #16912
fix: ignore case when matching function name #16912
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Does it make sense to add ignore case search in is_builtin_function(func_name) as well? |
Let's add a test in |
f64459f
to
5ad40f7
Compare
c08754d
to
d4bd725
Compare
Added a test |
Hi @notauserx You can continue after fixing conflicts, we're nearly at the end :) |
@notauserx Thanks for your contribution. |
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Update logic to search by the lowercase of func_name. Uses unicode crate to facilitate searching function name ignoring case
fixes: #16737
Tests
Type of change
This change is