Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storage): do compact before recluster during compact hook #16949

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

zhyass
Copy link
Member

@zhyass zhyass commented Nov 26, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Do compact before recluster during compact hook.

Restore the compact hook logic to ensure proper execution order(#16119). During a compact hook, perform the compaction first. If the table is a clustering table, execute recluster as a subsequent step. This ensures clustering-specific optimizations occur after the initial compaction process.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@zhyass zhyass changed the title chore: do compact before recluster during compact hook chore(storage): do compact before recluster during compact hook Nov 26, 2024
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Nov 26, 2024
@zhyass zhyass requested a review from dantengsky November 26, 2024 13:00
@dantengsky dantengsky added this pull request to the merge queue Nov 28, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Nov 28, 2024
@BohuTANG BohuTANG merged commit 2919b25 into databendlabs:main Nov 28, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants