Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: need_sticky field was incorrectly set to true. #16997

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented Dec 4, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

the bug happen only client do not poll pages until query finish or server crashed (server restart or client connect to another server in cluster) before that.

how to reproduce the bug with bendsql

  1. start a long running query
🐳 :) select * from numbers(1000000000000) ignore_result;
  1. restart server before it end

  2. start any new query in the same client session

🐳 :) select * from numbers(1000000000000) ignore_result;
error: APIError: QueryFailed: [4004]there are temp tables in session, but the request routed to the wrong server: current server is mTXoTYwSLlABvFt2h4zn41, the last is s0yzbB3qCV8WUp7Feq69w3.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Dec 4, 2024
@youngsofun youngsofun force-pushed the fix_temp_table branch 2 times, most recently from 3151842 to 6a28cfd Compare December 4, 2024 15:11
@youngsofun youngsofun added this pull request to the merge queue Dec 5, 2024
Merged via the queue into databendlabs:main with commit 3ca80b1 Dec 5, 2024
72 checks passed
@youngsofun youngsofun deleted the fix_temp_table branch December 5, 2024 03:55
@rad-pat
Copy link

rad-pat commented Dec 5, 2024

@youngsofun , would this fix error message that we saw for first time yesterday, with v1.2.665?

Exception: APIError: fail to fail to GET http://plaid-databend-query:8000/v1/query/f1b99b20-8bdb-4aff-8792-a581cd6a935a/final after 3 reties: BadRequest:(400 Bad Request)[400]Some(400) BadArguments. Code: 1006, Text = sticky_node_id 'OMBbfQjoD2NBuQ17kBq1w' not found in cluster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants