Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(query): reuse connection to fix dictionary mysql flaky test #17016

Merged
merged 4 commits into from
Dec 10, 2024
Merged

fix(query): reuse connection to fix dictionary mysql flaky test #17016

merged 4 commits into from
Dec 10, 2024

Conversation

b41sh
Copy link
Member

@b41sh b41sh commented Dec 9, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

reuse connections if dictionary have same source, fix dictionary mysql flaky test

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@b41sh b41sh requested a review from sundy-li December 9, 2024 05:43
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Dec 9, 2024
@b41sh b41sh added this pull request to the merge queue Dec 10, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 10, 2024
@b41sh b41sh added this pull request to the merge queue Dec 10, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Dec 10, 2024
@BohuTANG BohuTANG merged commit 644f17b into databendlabs:main Dec 10, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li sundy-li approved these changes

Assignees
No one assigned
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug]: flaky test of dictionary mysql
3 participants
@b41sh @sundy-li @BohuTANG