Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(binder): fix bind materialized cte #17046

Merged
merged 7 commits into from
Dec 17, 2024
Merged

chore(binder): fix bind materialized cte #17046

merged 7 commits into from
Dec 17, 2024

Conversation

Dousir9
Copy link
Member

@Dousir9 Dousir9 commented Dec 13, 2024 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Fixes: #17043

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Dec 13, 2024
@Dousir9 Dousir9 marked this pull request as ready for review December 17, 2024 01:11
@Dousir9 Dousir9 requested a review from xudong963 December 17, 2024 02:12
@Dousir9 Dousir9 added this pull request to the merge queue Dec 17, 2024
Merged via the queue into databendlabs:main with commit 572d958 Dec 17, 2024
78 checks passed
@Dousir9 Dousir9 deleted the fix_bind_materialized_cte branch December 17, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SkyFan2002 SkyFan2002 SkyFan2002 approved these changes

@xudong963 xudong963 xudong963 approved these changes

@zhang2014 zhang2014 Awaiting requested review from zhang2014

Assignees
No one assigned
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Encapsulate the table_name of m_cte in a separate namespace
3 participants
@Dousir9 @xudong963 @SkyFan2002