Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query): null type infer as Nullabel(String) by default in create as statement #17052

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

TCeason
Copy link
Collaborator

@TCeason TCeason commented Dec 16, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@TCeason TCeason marked this pull request as draft December 16, 2024 03:43
@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Dec 16, 2024
Copy link

what-the-diff bot commented Dec 16, 2024

PR Summary

  • Enhancement in Schema Type Identification:
    We made an improvement to how our program recognizes the type of data in each column. It now uses a new technique that better caters to instances where the data type is not specified, by assuming it as a nullable string type.

  • Removal of Redundant Testing Scenarios:
    We removed certain test scenarios that were unnecessary or unrelated. This improves the efficiency of our testing process.

  • New Testing Scenarios Introduced:
    We introduced new tests that check how well our program can create a new table with specific attributes - an integer and a nullable string. They also verify whether the table creation commands are displaying as expected. This is to ensure our program is handling table creation tasks correctly and consistently.

@TCeason TCeason marked this pull request as ready for review December 16, 2024 13:08
@TCeason TCeason enabled auto-merge December 16, 2024 13:08
@TCeason TCeason added this pull request to the merge queue Dec 16, 2024
Merged via the queue into databendlabs:main with commit f777d19 Dec 16, 2024
75 checks passed
@TCeason TCeason deleted the fix_16794 branch December 16, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: null type should infer as String Null by default in create as statement
2 participants