Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): fix thread leak and remove all usage #17081

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

dqhl76
Copy link
Collaborator

@dqhl76 dqhl76 commented Dec 19, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

fix(query): fix thread leak and remove all usage

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Dec 19, 2024
@dqhl76 dqhl76 marked this pull request as ready for review December 19, 2024 04:34
@dqhl76 dqhl76 requested a review from zhang2014 December 19, 2024 04:34
@zhang2014
Copy link
Member

0: query failed: Databend sqllogictests error: http query error: code: 3115, Text: Dictionary Sqlx Error, cause: pool timed out while waiting for an open connection
[SQL] select salary, dict_get(mysql_dic_salary, 'id', salary), dict_get(mysql_dic_salary, 'name', salary), dict_get(mysql_dic_salary, 'age', salary), dict_get(mysql_dic_salary, 'active', salary) from mysql_t
at tests/sqllogictests/suites/query/functions/02_0077_function_dict_get.test:274

flaky test and rerun.

@zhang2014 zhang2014 added this pull request to the merge queue Dec 19, 2024
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Dec 19, 2024
@BohuTANG BohuTANG merged commit 327cd75 into databendlabs:main Dec 19, 2024
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants