Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: databend-meta watch API provides initial_flush field #17098

Merged
merged 3 commits into from
Dec 24, 2024

Conversation

drmingdrmer
Copy link
Member

@drmingdrmer drmingdrmer commented Dec 23, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

feat: databend-meta watch API provides initial_flush field

If WatchRequest.initial_flush is true, when the watch stream is
established, all the key values in the specified range will be sent
through the stream to the watching client.

This allows the client to setup a full copy of the key range as a client
side cache, and furthur modifications will be received and the client
side cache can be updated.

chore: remove unused setting API

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • New Feature (non-breaking change which adds functionality)

Related Issues


This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Dec 23, 2024
@drmingdrmer drmingdrmer force-pushed the 189-flush-watch branch 2 times, most recently from fbac22c to 7d2c359 Compare December 23, 2024 08:35
@drmingdrmer drmingdrmer marked this pull request as ready for review December 23, 2024 11:28
@drmingdrmer drmingdrmer force-pushed the 189-flush-watch branch 2 times, most recently from caeec2c to e8a142d Compare December 24, 2024 06:12
If `WatchRequest.initial_flush` is `true`, when the watch stream is
established, all the key values in the specified range will be sent
through the stream to the watching client.

This allows the client to setup a full copy of the key range as a client
side cache, and furthur modifications will be received and the client
side cache can be updated.
@drmingdrmer drmingdrmer merged commit 5921c66 into databendlabs:main Dec 24, 2024
72 checks passed
@drmingdrmer drmingdrmer deleted the 189-flush-watch branch December 24, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants