Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): fix default values of SpillConfig may not take effect #17113

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

forsaken628
Copy link
Collaborator

@forsaken628 forsaken628 commented Dec 25, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

  1. Fix default values of SpillConfig may not take effect
  2. Enable local spill in ci logic test

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Dec 25, 2024
@forsaken628 forsaken628 requested a review from Xuanwo December 25, 2024 07:26
@forsaken628 forsaken628 marked this pull request as ready for review December 25, 2024 08:18
@wubx
Copy link
Member

wubx commented Dec 26, 2024

LGTM

@BohuTANG BohuTANG merged commit 6eea9b4 into databendlabs:main Dec 26, 2024
78 checks passed
@BohuTANG BohuTANG added the ci-benchmark Benchmark: run all test label Dec 26, 2024
@forsaken628 forsaken628 deleted the fix-config branch December 26, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-benchmark Benchmark: run all test pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants