Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(query): reduce-functions-code-expand #17114

Merged
merged 7 commits into from
Dec 27, 2024
Merged

chore(query): reduce-functions-code-expand #17114

merged 7 commits into from
Dec 27, 2024

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Dec 25, 2024 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

reduce-functions-code-expand

continue #16961

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Dec 25, 2024
@sundy-li
Copy link
Member Author

sundy-li commented Dec 25, 2024 •
edited
Loading

image

After 32s, there is only one crate left which causes most building times: common-functions.

We should split this crate into multi crates.

@sundy-li sundy-li requested review from TCeason, b41sh and Xuanwo December 25, 2024 09:36
Xuanwo
Xuanwo approved these changes Dec 25, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this!

@sundy-li sundy-li mentioned this pull request Dec 25, 2024
Closed
@sundy-li sundy-li added the ci-benchmark Benchmark: run all test label Dec 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-17114-32806f7-1735176679

note: this image tag is only available for internal use,
please check the internal doc for more details.

@github-actions GitHub Actions
Copy link
Contributor

ClickBench Report

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

ClickBench Report

@sundy-li sundy-li marked this pull request as draft December 26, 2024 03:53
@sundy-li sundy-li removed the ci-benchmark Benchmark: run all test label Dec 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

ClickBench Report

@sundy-li sundy-li marked this pull request as ready for review December 26, 2024 06:19
@sundy-li sundy-li enabled auto-merge December 26, 2024 06:19
@sundy-li
Copy link
Member Author

Perf tests are not related to this pr.

@sundy-li sundy-li added this pull request to the merge queue Dec 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 26, 2024
@sundy-li sundy-li added ci-benchmark Benchmark: run all test ci-benchmark-cloud Benchmark: run only cloud tests for tpch/hits and removed ci-benchmark Benchmark: run all test labels Dec 26, 2024
@sundy-li sundy-li removed the ci-benchmark-cloud Benchmark: run only cloud tests for tpch/hits label Dec 26, 2024
@sundy-li sundy-li force-pushed the reduce-functions-code-expand branch from ae54413 to 7e59a20 Compare December 26, 2024 10:35
@BohuTANG BohuTANG merged commit 1f9a4eb into databendlabs:main Dec 27, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@b41sh b41sh b41sh approved these changes

@TCeason TCeason Awaiting requested review from TCeason

Assignees
No one assigned
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sundy-li @b41sh @Xuanwo @BohuTANG