Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: integrate segment pruning into pipeline #17126

Merged
merged 3 commits into from
Dec 28, 2024
Merged

refactor: integrate segment pruning into pipeline #17126

merged 3 commits into from
Dec 28, 2024

Conversation

dqhl76
Copy link
Collaborator

@dqhl76 dqhl76 commented Dec 26, 2024 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

integrate segment pruning into pipeline

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-refactor this PR changes the code base without new features or bugfix label Dec 26, 2024
@dqhl76 dqhl76 added ci-benchmark Benchmark: run all test and removed ci-benchmark Benchmark: run all test labels Dec 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

Docker Image for PR

  • tag: pr-17126-60304ca-1735284711

note: this image tag is only available for internal use,
please check the internal doc for more details.

@github-actions GitHub Actions
Copy link
Contributor

ClickBench Report

@dqhl76 dqhl76 marked this pull request as ready for review December 27, 2024 08:12
@dqhl76 dqhl76 requested a review from zhang2014 December 27, 2024 08:12
@BohuTANG
Copy link
Member

ClickBench - TPC-H Small Performance Degradation

image

TPC-H Small benchmark result

@dqhl76
Copy link
Collaborator Author

dqhl76 commented Dec 27, 2024

ClickBench - TPC-H Small Performance Degradation

I reran the TPC-H Small benchmark, and the observed performance degradation appears to be a false positive.
https://github.com/databendlabs/databend/actions/runs/12512950258/job/34908874174?pr=17126
image
image

@github-actions GitHub Actions
Copy link
Contributor

ClickBench Report

@zhang2014 zhang2014 added this pull request to the merge queue Dec 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 28, 2024
@BohuTANG BohuTANG merged commit 7392cdb into databendlabs:main Dec 28, 2024
90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhang2014 zhang2014 zhang2014 approved these changes

Assignees
No one assigned
Labels
pr-refactor this PR changes the code base without new features or bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dqhl76 @BohuTANG @zhang2014