Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(log): prefix_filter not working. #17136

Merged
merged 1 commit into from
Dec 29, 2024
Merged

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented Dec 29, 2024

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

after this fix, with the following configuration, only Databend’s own logs will be retained in the log.

[log]

[log.file]
...
prefix_filter = "databend_,openraft"

cc @wubx

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@youngsofun youngsofun requested a review from sundy-li December 29, 2024 01:51
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Dec 29, 2024
Copy link
Member

@drmingdrmer drmingdrmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @sundy-li)

@wubx
Copy link
Member

wubx commented Dec 29, 2024

The product configuration is

prefix_filter=""

Because I want to get OpenDal's error report.

BTW:

What specific values can be configured in the prefix_filter?

@drmingdrmer
Copy link
Member

The product configuration is

prefix_filter=""

Because I want to get OpenDal's error report.

BTW:

What specific values can be configured in the prefix_filter?

prefix_filter="databend_,opendal"

@wubx
Copy link
Member

wubx commented Dec 29, 2024

The product configuration is

prefix_filter=""

Because I want to get OpenDal's error report.
BTW:
What specific values can be configured in the prefix_filter?

prefix_filter="databend_,opendal"

Please provide a list of supported items in prefilter_filter

@drmingdrmer
Copy link
Member

The product configuration is

prefix_filter=""

Because I want to get OpenDal's error report.
BTW:
What specific values can be configured in the prefix_filter?

prefix_filter="databend_,opendal"

Please provide a list of supported items in prefilter_filter

The items in this list are crate name prefixes. For example databend_ matches all databend crates, open matches openraft and opendal.

@youngsofun youngsofun added this pull request to the merge queue Dec 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 29, 2024
@youngsofun youngsofun added this pull request to the merge queue Dec 29, 2024
Merged via the queue into databendlabs:main with commit 8f2230b Dec 29, 2024
85 of 88 checks passed
@youngsofun youngsofun deleted the fixlog branch December 29, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants