Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(query): support direct the spill data to a different bucket #17159

Merged
merged 18 commits into from
Jan 6, 2025

Conversation

forsaken628
Copy link
Collaborator

@forsaken628 forsaken628 commented Jan 2, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-feature this PR introduces a new feature to the codebase label Jan 2, 2025
@forsaken628 forsaken628 requested a review from Xuanwo January 2, 2025 11:14
@forsaken628 forsaken628 requested a review from sundy-li January 3, 2025 02:07
@Xuanwo
Copy link
Member

Xuanwo commented Jan 3, 2025

We are modifying as much code as we are adding with spill.storage, so why not use spill.storage instead? Adding a spill_bucket doesn’t seem like a good idea to me.

It’s also difficult to document for users. For instance, there is no bucket concept in azblob. We could reuse all the documents we have written for storage instead of explaining what spill_bucket is and how it interacts with other options in storage.

@forsaken628 forsaken628 force-pushed the spill-config branch 2 times, most recently from 66a3274 to 0503d61 Compare January 3, 2025 08:15
@forsaken628
Copy link
Collaborator Author

/// Storage config group.
///
/// # TODO(xuanwo)
///
/// In the future, we will use the following storage config layout:
///
/// ```toml
/// [storage]
///
/// [storage.data]
/// type = "s3"
///
/// [storage.temporary]
/// type = "s3"
/// ```

This is a better layout, but there's no time to refactor it.

@forsaken628 forsaken628 marked this pull request as ready for review January 3, 2025 12:01
@sundy-li
Copy link
Member

sundy-li commented Jan 3, 2025

We need a test to cover that spill could work out with other storage params.

Maybe add other test bucket like tests/suites/1_stateful/00_stage/00_0009_remove_internal_stage.sh

@sundy-li sundy-li added this pull request to the merge queue Jan 6, 2025
Merged via the queue into databendlabs:main with commit 783d155 Jan 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature this PR introduces a new feature to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement spill fallback logic during runtime feat: add storage.spill bucket
3 participants