-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: adjust fuse_time_travel_size() #17164
chore: adjust fuse_time_travel_size() #17164
Conversation
c7bedf2
to
56aa349
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A test should be added to ensure non-retainable tables are returned as expected
Reviewed 4 of 7 files at r1, all commit messages.
Reviewable status: 4 of 7 files reviewed, 4 unresolved discussions (waiting on @dantengsky, @SkyFan2002, and @TCeason)
src/meta/api/src/schema_api.rs
line 230 at r1 (raw file):
include_non_retainable: bool, req: ListTableReq, ) -> Result<Vec<TableNIV>, KVAppError>;
The method name should be updated too, if it returns both retainable and non-retainable tables.
Code quote:
async fn list_retainable_tables(
&self,
include_non_retainable: bool,
req: ListTableReq,
) -> Result<Vec<TableNIV>, KVAppError>;
src/meta/api/src/schema_api_impl.rs
line 3068 at r1 (raw file):
async fn get_retainable_table_metas( kv_api: &(impl kvapi::KVApi<Error = MetaError> + ?Sized), include_non_retainable: bool,
Update method name
Code quote:
async fn get_retainable_table_metas(
kv_api: &(impl kvapi::KVApi<Error = MetaError> + ?Sized),
include_non_retainable: bool,
src/query/service/src/databases/default/default_database.rs
line 199 at r1 (raw file):
&self, include_non_retainable: bool, ) -> Result<Vec<Arc<dyn Table>>> {
update method name
Code quote:
async fn list_tables_history(
&self,
include_non_retainable: bool,
) -> Result<Vec<Arc<dyn Table>>> {
src/query/service/src/databases/default/default_database.rs
line 211 at r1 (raw file):
include_non_retainable, ListTableReq::new(self.get_tenant(), self.db_info.database_id), )
update method name
Code quote:
.list_retainable_tables(
include_non_retainable,
ListTableReq::new(self.get_tenant(), self.db_info.database_id),
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 7 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dantengsky and @TCeason)
751f4bb
to
33c6c56
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM this logic not impact db and tables with history.
I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/
Summary
Tests
Type of change
This change is