Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove unused settings for ssl #17173

Merged
merged 2 commits into from
Jan 6, 2025
Merged

chore: Remove unused settings for ssl #17173

merged 2 commits into from
Jan 6, 2025

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Jan 6, 2025 •
edited by drmingdrmer
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe): chore

This change is Reviewable

@Xuanwo Xuanwo requested a review from dantengsky January 6, 2025 05:48
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Jan 6, 2025
@BohuTANG
Copy link
Member

BohuTANG commented Jan 6, 2025

Conflicts:
src/query/settings/src/settings_default.rs
src/query/settings/src/settings_getter_setter.rs

@Xuanwo Xuanwo enabled auto-merge January 6, 2025 12:32
@Xuanwo Xuanwo added this pull request to the merge queue Jan 6, 2025
Merged via the queue into databendlabs:main with commit 9c56abd Jan 6, 2025
72 checks passed
@Xuanwo Xuanwo deleted the remove-unused-settings branch January 6, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantengsky dantengsky dantengsky approved these changes

Assignees
No one assigned
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: remove unused settings premise_deploy*
3 participants
@Xuanwo @BohuTANG @dantengsky