Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: check schema for small parquet file too. #17175

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

youngsofun
Copy link
Member

@youngsofun youngsofun commented Jan 6, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

before this pr, when try loading small parquet files with diff schema, user may encounter error like

error: APIError: QueryFailed: [1104]index out of bounds: the len is 4 but the index is 4.

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Jan 6, 2025
@youngsofun youngsofun requested review from b41sh and sundy-li January 6, 2025 10:15
Copy link
Member

@b41sh b41sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
We'd better support reading different schema pqrquet files in future PR, it's a common situation for users to add and delete fields.

@BohuTANG BohuTANG merged commit 99cb6e1 into databendlabs:main Jan 6, 2025
83 of 87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants