Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): check state is allocated or not when oom #17179

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Jan 6, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

fix(query): check state is allocated or not when oom

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@sundy-li sundy-li requested a review from zhang2014 January 6, 2025 13:45
@github-actions github-actions bot added the pr-chore this PR only has small changes that no need to record, like coding styles. label Jan 6, 2025
@sundy-li sundy-li changed the title chore(query): use CommonHashSet to store AggregateUniqStringState fix(query): check state is allocated or not when oom Jan 6, 2025
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Jan 6, 2025
@BohuTANG BohuTANG merged commit a070678 into databendlabs:main Jan 6, 2025
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase pr-chore this PR only has small changes that no need to record, like coding styles.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants