Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: name resolution bug in quoted ident case sensitive mode #17198

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

zhyass
Copy link
Member

@zhyass zhyass commented Jan 7, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Fix name resolution bug in quoted ident case sensitive mode.
The bug:

mysql> create table t(a int);
Query OK, 0 rows affected (0.15 sec)

mysql> create stream `S1` on table t;
Query OK, 0 rows affected (0.12 sec)

mysql> select * from `S1`;
ERROR 1105 (HY000): UnknownTable. Code: 1025, Text = error: 
  --> SQL:1:19
  |
1 | select * from `S1`
  |                     Unknown table "default".default.S1 (unquoted). Did you mean "S1" (quoted)?

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@zhyass zhyass requested review from zhang2014 and dantengsky January 7, 2025 14:22
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Jan 7, 2025
@zhyass zhyass enabled auto-merge January 8, 2025 03:43
@zhyass zhyass added this pull request to the merge queue Jan 8, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 8, 2025
@BohuTANG BohuTANG merged commit a83eb8f into databendlabs:main Jan 8, 2025
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants