Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): stick the created_by infos in parquet writer #17220

Merged
merged 5 commits into from
Jan 9, 2025

Conversation

sundy-li
Copy link
Member

@sundy-li sundy-li commented Jan 8, 2025

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

fix(query): stick the created_by infos in parquet writer

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test - Explain why

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Jan 8, 2025
@BohuTANG
Copy link
Member

BohuTANG commented Jan 9, 2025

Looks the PR always failed at:

thread 'main' panicked at tests/sqllogictests/src/main.rs:216:22:
called `Result::unwrap()` on an `Err` value: Client(CreateContainer(RequestTimeoutError))

@b41sh
Copy link
Member

b41sh commented Jan 9, 2025

Looks the PR always failed at:

thread 'main' panicked at tests/sqllogictests/src/main.rs:216:22:
called `Result::unwrap()` on an `Err` value: Client(CreateContainer(RequestTimeoutError))

I will fix this problem

@sundy-li sundy-li added this pull request to the merge queue Jan 9, 2025
@BohuTANG BohuTANG removed this pull request from the merge queue due to a manual request Jan 9, 2025
@BohuTANG BohuTANG merged commit 111d659 into databendlabs:main Jan 9, 2025
70 checks passed
sundy-li added a commit to sundy-li/databend that referenced this pull request Jan 9, 2025
…s#17220)

* fix(query): stick the created_by infos in parquet writer

* fix(query): stick the created_by infos in parquet writer

* fix(query): stick the created_by infos in parquet writer

* fix(query): stick the created_by infos in parquet writer

* fix(query): stick the created_by infos in parquet writer
BohuTANG pushed a commit that referenced this pull request Jan 9, 2025
…ter (#17223)

* fix(query): stick the created_by infos in parquet writer (#17220)

* fix(query): stick the created_by infos in parquet writer

* fix(query): stick the created_by infos in parquet writer

* fix(query): stick the created_by infos in parquet writer

* fix(query): stick the created_by infos in parquet writer

* fix(query): stick the created_by infos in parquet writer

* fix(query): fix register function working with nullable scalar (#17217)

* fix(query): fix register function working with nullable scalar

* fix(query): fix register function working with nullable scalar

* fix(query): increase pool

* Update 19_0005_fuzz_cte.sh

* Update mysql_source.rs

* fix(query): fix register function working with nullable scalar

* fix(query): rollback tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants