Use Chrono without default features #914
Labels
bug
Something isn't working
Comments
|
I'm in favor of this. Feel free to open a PR and I am happy to review. 👍 |
roeap
added a commit
that referenced
this issue
Dec 30, 2022
# Description ~~This PR updates datafusion and related dependencies to their latest versions. Since datafusion now has improved support for loading partition columns with non string types, we update our scan methods to take advantage of that.~~ While working on dependencies, I took the opportunity to do some housekeeping. - do not use chrono with default features - make `aws-profile` from object_store optional. The upstream create explicitly discourages its usage, and it brings quite a few new dependencies, as it pulls in some aws sdk. - rename `datafusion-ext` feature to `datafusion`. The ext suffix is still from a time where there were less options to define features. I kept the ols feature around as an alias. # Related Issue(s) closes #914 # Documentation <!--- Share links to useful documentation ---> Co-authored-by: R. Tyler Croy <[email protected]>
chitralverma
pushed a commit
to chitralverma/delta-rs
that referenced
this issue
Mar 17, 2023
# Description ~~This PR updates datafusion and related dependencies to their latest versions. Since datafusion now has improved support for loading partition columns with non string types, we update our scan methods to take advantage of that.~~ While working on dependencies, I took the opportunity to do some housekeeping. - do not use chrono with default features - make `aws-profile` from object_store optional. The upstream create explicitly discourages its usage, and it brings quite a few new dependencies, as it pulls in some aws sdk. - rename `datafusion-ext` feature to `datafusion`. The ext suffix is still from a time where there were less options to define features. I kept the ols feature around as an alias. # Related Issue(s) closes delta-io#914 # Documentation <!--- Share links to useful documentation ---> Co-authored-by: R. Tyler Croy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Chrono currently (version 0.4.22) by default enables the "oldtime" feature, which is for compatibility. It also introduces this rustsec issue, https://rustsec.org/advisories/RUSTSEC-2020-0071
To the best of my understanding chrono does not need this feature enabled, would it be possible to do this? I am happy to put in a PR if maintainers are onboard with the change.
The text was updated successfully, but these errors were encountered: