Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update Readme #1440

Merged
merged 21 commits into from
Sep 15, 2023
Merged

docs: update Readme #1440

merged 21 commits into from
Sep 15, 2023

Conversation

roeap
Copy link
Collaborator

@roeap roeap commented Jun 5, 2023

Description

With summit coming up I thought we might update our README, since delta-rs has evolved quite a bit since the README was first written...

Just opening the Draft to get feedback on the general "patterns" i.e. how the tables are formatted, how detailed we want to show the features and mostly the looks of the header.

Also hoping our community experts may have some content they wat to add here 😆.

cc @dennyglee @MrPowers @wjones127 @rtyler @houqp @fvaleye

@github-actions github-actions bot added the binding/python Issues for the Python package label Jun 5, 2023
@github-actions
Copy link

github-actions bot commented Jun 5, 2023

ACTION NEEDED

delta-rs follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

@roeap roeap changed the title Readme docs: update Readme Jun 5, 2023
Copy link
Collaborator

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking better. I had a few suggestions

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
python/pyproject.toml Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of adding a "Powered By" section and listing Apache Arrow and DataFusion?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 especially from the context that we're updating delta.rs to keep up with them, eh?! ;)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we then also submit a PR to the official arrow "pwered_by" section?

https://arrow.apache.org/powered_by/

REA_DME.adoc Outdated Show resolved Hide resolved
Comment on lines +35 to +37
<a target="_blank" href="https://go.delta.io/slack">
<img alt="#delta-rs in the Delta Lake Slack workspace" src="https://img.shields.io/badge/slack-delta-blue.svg?logo=slack&style=flat-square&color=F75101">
</a>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add back a "Get involved section"?

Could list:

Copy link
Collaborator

@dennyglee dennyglee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice, thanks for tackling this. Minor suggestions noted.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 especially from the context that we're updating delta.rs to keep up with them, eh?! ;)

| Storage | Rust | Python | Comment |
| -------------------- | :-------------------: | :-------------------: | ----------------------------------- |
| Local | ![done] | ![done] | |
| S3 - AWS | ![done] | ![done] | requires lock for concurrent writes |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we point to the docs to explain how to spin up DynamoDB for the lock?

README.md Show resolved Hide resolved
README.md Outdated
</a>
</p>

The delta-rs project aims to unlock the power of the Deltalake for as many users and projects as possible
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update to "Delta Lake"

README.md Outdated

The delta-rs project aims to unlock the power of the Deltalake for as many users and projects as possible
by providing native low level APIs aimed at developers and integrators, as well as a high level operations
API that lets you query, inspect, and operate your Deltalake with ease.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update to "Delta Lake"

README.md Outdated

## Quick Start

The deltalake library aim to adopt familiar patterns from other libraries in data processing,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest either "The Delta Lake library aims to..." or "The deltalake library aims to..."

Co-authored-by: Will Jones <[email protected]>
@MrPowers
Copy link
Contributor

MrPowers commented Jun 6, 2023

Looks like some great improvements!

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 6, 2023
README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on typo

README.md Outdated
| Writer Version | Requirement | Status |
| -------------- | --------------------------------------------- | :------------------: |
| Version 2 | Append Only Tables | [![open]][roadmap] |
| Version 2 | Column Invatiants | ![done] |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little typo here (Invatiants => Invariants)

README.md Outdated Show resolved Hide resolved
@rtyler rtyler marked this pull request as ready for review July 15, 2023 05:13
rtyler
rtyler previously approved these changes Jul 15, 2023
@rtyler rtyler enabled auto-merge (squash) July 15, 2023 05:13
@rtyler rtyler self-assigned this Jul 15, 2023
@rtyler rtyler dismissed dennyglee’s stale review September 15, 2023 04:46

outdated, clearing the queue

@rtyler rtyler merged commit 4638fcf into delta-io:main Sep 15, 2023
@roeap roeap deleted the readme branch September 25, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/python Issues for the Python package documentation Improvements or additions to documentation