feat: use url parsing from object store #1592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roeap
requested review from
houqp,
xianwill,
wjones127,
fvaleye,
rtyler and
mosyp
as code owners
roeap
force-pushed
the
storage-config
branch
5 times, most recently
from
f5ea94f to
7c3d8c1
Compare
vipeller
reviewed
Sep 8, 2023
| ("hdfs", Some(_)) => (Self::Hdfs, url.path()), | ||
| ("https", Some(host)) => { | ||
| if host.ends_with("dfs.core.windows.net") || host.ends_with("blob.core.windows.net") | ||
| { |
There was a problem hiding this comment.
this does not seem to have the latest object store changes for fabric support
There was a problem hiding this comment.
will definately add that !
rtyler
force-pushed
the
storage-config
branch
from
c4e0a6b to
bfa0202
Compare
roeap
force-pushed
the
storage-config
branch
from
bfa0202 to
ea3fbef
Compare
roeap
force-pushed
the
storage-config
branch
4 times, most recently
from
58a25ee to
d45cc68
Compare
roeap
force-pushed
the
storage-config
branch
2 times, most recently
from
53caeaa to
d5a9e14
Compare
roeap
force-pushed
the
storage-config
branch
from
d5a9e14 to
1035ccb
Compare
rtyler
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the url parsing and options to the object store implementation where applicable. This also provides a fix for a subtle bug we had in our configuration handling. Specifically in certain scenarios we may choose an unexpected credential. If the user passed in configuration for a credential, but there is another credential defined in the environment, the choice of credential depends on the order credentials are checked within object store.
While not completely robust, we now try to create a credential without info added from the environment, and if that fails, augment the options with specs from the environment.
closes #1356