Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add comment to explain why assert has failed and show state #2179

Merged

Conversation

braaannigan
Copy link
Contributor

Description

Add comment to explain why assert has failed for partition_by columns and show state

Related Issue(s)

closes #2177

@github-actions github-actions bot added the binding/python Issues for the Python package label Feb 9, 2024
Copy link

github-actions bot commented Feb 9, 2024

ACTION NEEDED

delta-rs follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

@braaannigan braaannigan changed the title Add comment to explain why assert has failed and show state (feat,pythin) Add comment to explain why assert has failed and show state Feb 9, 2024
@braaannigan braaannigan changed the title (feat,pythin) Add comment to explain why assert has failed and show state (feat,python) Add comment to explain why assert has failed and show state Feb 9, 2024
@braaannigan braaannigan changed the title (feat,python) Add comment to explain why assert has failed and show state (feat,python): Add comment to explain why assert has failed and show state Feb 9, 2024
@braaannigan braaannigan changed the title (feat,python): Add comment to explain why assert has failed and show state (feat,python): add comment to explain why assert has failed and show state Feb 9, 2024
@braaannigan braaannigan changed the title (feat,python): add comment to explain why assert has failed and show state feat: add comment to explain why assert has failed and show state Feb 9, 2024
@ion-elgreco
Copy link
Collaborator

@braaannigan I think you ran black while we use ruff for formatting, can you run ruff format over it?

@braaannigan
Copy link
Contributor Author

@braaannigan I think you ran black while we use ruff for formatting, can you run ruff format over it?

Cheers, I've tried again

Copy link
Collaborator

@ion-elgreco ion-elgreco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @braaannigan

@ion-elgreco ion-elgreco merged commit 02fa4c2 into delta-io:main Feb 10, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/python Issues for the Python package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add error message for parition_by check
2 participants