feat: support time type #2283
Closed
feat: support time type #2283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
binding/python
|
@rebasedming if we would merge this, then it would break Delta protocol compatibility, which would not allow other writers or reader implementations to read delta tables. You would need to put a feature request in at delta repo, like this one delta-io/delta#2319 |
|
Yeah, if it's not in the protocol it's very unlikely this will be accepted. |
|
I wonder if we should at least write some additional metadata as to what the original arrow type was. This way, it'd be fully compatible with the delta spec, and arrow users could still retain the original information too. Then the user could just parse that metadata and either cast, or decode directly to the original type. This would also fix this issue #2162 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
TimePrimitiveTypeso thatDeltaTables support the Arrow time type. Nanosecond precision was chosen to align with DataFusion's default time precision.I'm opening this as draft since there was discussion in the related issue about how time is not supported by the delta protocol. I'm curious to understand what the consequences of that would be wrt merging this PR -- please let me know in the comments!
Related Issue(s)
Time32andTime64types #2272Documentation