fix: expression with dates to string conversation #3019
Merged
+17
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonasDev1
requested review from
wjones127,
roeap,
rtyler,
hntd187 and
ion-elgreco
as code owners
|
ACTION NEEDED delta-rs follows the Conventional Commits specification for release automation. The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
JonasDev1
changed the title
JonasDev1
force-pushed
the
fix-date-expr-to-string
branch
from
f776584 to
bd549cf
Compare
Signed-off-by: Jonas Schmitz <[email protected]>
ion-elgreco
force-pushed
the
fix-date-expr-to-string
branch
from
bd549cf to
ec9be94
Compare
|
supersedes this: #2463 Thanks for finishing this! @JonasDev1 can you update the python tests asserts, then we are good to go |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3019 +/- ##
==========================================
+ Coverage 72.44% 72.47% +0.03%
==========================================
Files 128 128
Lines 40841 40853 +12
Branches 40841 40853 +12
==========================================
+ Hits 29587 29610 +23
+ Misses 9363 9359 -4
+ Partials 1891 1884 -7 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Signed-off-by: Jonas Schmitz <[email protected]>
Signed-off-by: Jonas Schmitz <[email protected]>
auto-merge was automatically disabled
November 22, 2024 13:31
Head branch was pushed to by a user without write access
ion-elgreco
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the expr to str conversation was an issue for dates.
Before this expr
lit(ScalarValue::Date32(Some(18262)))was converted to_date = 2020-01-01. If you want to parse this string again as an expr it will result into...BinaryExpr(**BinaryExpr { left: BinaryExpr(BinaryExpr { left: Literal(Int64(2020)), op: Minus, right: Literal(Int64(1)) })...which is not correct.Now
lit(ScalarValue::Date32(Some(18262)))will be converted to_date = '2020-01-01'::date, which will be parsed a as date again.Related Issue(s)