Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add steps to install uv in venv #3085

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

FranArenas
Copy link
Contributor

Description

uv is needed to use the make file for development, but uv is not installed in the venv and there is not a command to activate the venv.

This PR adds the sh command to activate the venv and the command to install uv before executing the Makefile.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 25, 2024
Copy link

ACTION NEEDED

delta-rs follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

@ion-elgreco
Copy link
Collaborator

UV should actually be installed globally, I would just put a link to the UV installation for this

@FranArenas FranArenas force-pushed the contributors-md-python-env branch from 16354b3 to cfe6cb1 Compare December 25, 2024 11:19
@FranArenas
Copy link
Contributor Author

UV should actually be installed globally, I would just put a link to the UV installation for this

Makes sense, I just added the link to the uv repo and warned about the need of the tool.

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.32%. Comparing base (72311ed) to head (cfe6cb1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3085      +/-   ##
==========================================
+ Coverage   72.29%   72.32%   +0.03%     
==========================================
  Files         128      128              
  Lines       41165    41165              
  Branches    41165    41165              
==========================================
+ Hits        29761    29774      +13     
  Misses       9492     9492              
+ Partials     1912     1899      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ion-elgreco ion-elgreco added this pull request to the merge queue Dec 26, 2024
Merged via the queue into delta-io:main with commit 24bbcdb Dec 26, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants