[UI] Convert all favicon to png format for tracker icons #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the potential for favicon's on-site to be in either png OR ico format, I've opted to convert and resize favicon to .png of at max 16x16.
Previously, any sites that did not use .png and met the 16x16 threshold for their favicon would actually fail to load in the GTK tracker list. Only favicons that were resized/converted to png or were natively in png would load.
With this change, all fav icons end up as .png and within the max size, displaying 100% of the trackers with favicon's on the domain in the GTK tracker list properly.