-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(Emoji)!: make imageURL() changing extension dynamically #10613
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Co-authored-by: Aura <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10613 +/- ##
=======================================
Coverage 37.96% 37.96%
=======================================
Files 239 239
Lines 14877 14877
Branches 1377 1378 +1
=======================================
Hits 5648 5648
Misses 9218 9218
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
idk if the docs/typings for |
Please describe the changes this PR makes and why it should be merged:
I think it'd be better if
Emoji#imageURL()
changes the extension dynamically as others...URL()
functions.Status and versioning classification: